Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-data derived QA check IDs don't match format of actual QA checks #6472

Closed
Thingus opened this issue Mar 20, 2024 · 0 comments · Fixed by #6470
Closed

Test-data derived QA check IDs don't match format of actual QA checks #6472

Thingus opened this issue Mar 20, 2024 · 0 comments · Fixed by #6470

Comments

@Thingus
Copy link
Contributor

Thingus commented Mar 20, 2024

Describe the bug
Test data QA check IDs are of the form [check_name].sql; they should be of the form [check_name].[cdr_type] (if cdr_type is relevant.

Product
flowdb

Version
Latest

To Reproduce
Build flowdb_synthetic_data or flowdb_test_data and inspect etl.deduped_post_etl_queries

Expected behavior
Check IDs should be of the form specified in

FlowKit/flowetl/flowetl/flowetl/util.py

Line 90 in ba9948f

task_id=(

@Thingus Thingus mentioned this issue Mar 20, 2024
Merged
8 tasks
@mergify mergify bot closed this as completed in #6470 Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test qa data rename Flowminder/FlowKit
1 participant
@Thingus