Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoanalyze cache tables #6599

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Autoanalyze cache tables #6599

merged 2 commits into from
Jun 12, 2024

Conversation

greenape
Copy link
Member

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Triggers an explicit analyze on newly created cache tables so they are guaranteed to have statistics before being used in another query.

@greenape greenape added enhancement New feature or request FlowMachine Issues related to FlowMachine performance labels May 15, 2024
@greenape greenape requested a review from jc-harrison May 15, 2024 10:39
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.11%. Comparing base (e30ce06) to head (fbe2160).

Files Patch % Lines
flowmachine/flowmachine/core/cache.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6599       +/-   ##
===========================================
- Coverage   92.30%   77.11%   -15.20%     
===========================================
  Files         268      268               
  Lines       10586    10590        +4     
  Branches      855      856        +1     
===========================================
- Hits         9771     8166     -1605     
- Misses        676     2169     +1493     
- Partials      139      255      +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label May 22, 2024
Copy link

cypress bot commented Jun 11, 2024

Passing run #22813 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge branch 'master' into autoanalyze-cache-tables
Project: FlowAuth Commit: fbe2160010
Status: Passed Duration: 00:47 💡
Started: Jun 12, 2024 9:32 AM Ended: Jun 12, 2024 9:33 AM

Review all test suite changes for PR #6599 ↗︎

Copy link
Member

@jc-harrison jc-harrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 1b330ea into master Jun 12, 2024
39 of 41 checks passed
@mergify mergify bot deleted the autoanalyze-cache-tables branch June 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowMachine Issues related to FlowMachine performance ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants