Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json logs #6600

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Json logs #6600

merged 4 commits into from
Jun 14, 2024

Conversation

greenape
Copy link
Member

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Adds a new env var, FLOWDB_LOG_DEST which controls the log destination config item, and changes the default to json files.

@greenape greenape added enhancement New feature or request FlowDB Issues related to FlowDB labels May 15, 2024
@greenape greenape requested a review from jc-harrison May 15, 2024 12:48
Copy link

cypress bot commented May 15, 2024

1 failed and 2 flaky tests on run #22873 ↗︎

1 36 0 6 Flakiness 2

Details:

Merge branch 'master' into json-logs
Project: FlowAuth Commit: ea0c5779b2
Status: Failed Duration: 02:11 💡
Started: Jun 14, 2024 8:32 PM Ended: Jun 14, 2024 8:34 PM
Failed  cypress/e2e/role_list.js • 1 failed test

View Output

Test Artifacts
role list screen > Add blank role Test Replay Screenshots
Flakiness  cypress/e2e/add_new_server.js • 2 flaky tests

View Output

Test Artifacts
Server management > Add duplicate Server name Test Replay Screenshots
Server management > Add server Test Replay Screenshots

Review all test suite changes for PR #6600 ↗︎

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.30%. Comparing base (4ae810e) to head (36a3320).

Current head 36a3320 differs from pull request most recent head ea0c577

Please upload reports for the commit ea0c577 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6600   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files         268      268           
  Lines       10590    10590           
  Branches      856      856           
=======================================
  Hits         9775     9775           
  Misses        676      676           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label May 22, 2024
@greenape greenape requested review from Thingus and jakejellinek and removed request for jc-harrison June 12, 2024 08:49
Copy link
Contributor

@Thingus Thingus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved modulo thought about config for rotation age+size

flowdb/bin/build/pg_config_template.conf Show resolved Hide resolved
@greenape greenape merged commit f9efde0 into master Jun 14, 2024
34 of 39 checks passed
@greenape greenape deleted the json-logs branch June 14, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowDB Issues related to FlowDB ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants