Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying auto config path #6601

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

greenape
Copy link
Member

@greenape greenape commented May 16, 2024

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Description of what this PR does, and what it changes.


@greenape greenape added enhancement New feature or request FlowDB Issues related to FlowDB labels May 16, 2024
@greenape greenape requested a review from jc-harrison May 16, 2024 10:42
@greenape greenape force-pushed the allow-specifying-auto-config-path branch from 2e836bd to 1cf51a4 Compare May 16, 2024 10:49
Copy link

cypress bot commented May 16, 2024

Passing run #22877 ↗︎

0 4 0 0 Flakiness 0

Details:

Make the autoconfig filename configurable via env var
Project: FlowAuth Commit: 5a38c0edff
Status: Passed Duration: 00:47 💡
Started: Jun 14, 2024 9:01 PM Ended: Jun 14, 2024 9:02 PM

Review all test suite changes for PR #6601 ↗︎

@greenape greenape force-pushed the allow-specifying-auto-config-path branch 3 times, most recently from 9a007b8 to 6a43839 Compare May 16, 2024 12:13
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.11%. Comparing base (f9efde0) to head (5a38c0e).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6601       +/-   ##
===========================================
- Coverage   92.30%   77.11%   -15.20%     
===========================================
  Files         268      268               
  Lines       10590    10590               
  Branches      856      856               
===========================================
- Hits         9775     8166     -1609     
- Misses        676     2169     +1493     
- Partials      139      255      +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label May 22, 2024
@greenape greenape requested review from Thingus and jakejellinek and removed request for jc-harrison June 12, 2024 08:48
Copy link
Contributor

@Thingus Thingus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greenape greenape mentioned this pull request Jun 14, 2024
8 tasks
@greenape greenape force-pushed the allow-specifying-auto-config-path branch 2 times, most recently from fc8ff3a to 1c4f1a7 Compare June 14, 2024 20:49
And move it internally for easy bind mounting
@greenape greenape force-pushed the allow-specifying-auto-config-path branch from 1c4f1a7 to 5a38c0e Compare June 14, 2024 20:52
@mergify mergify bot merged commit fdf87e8 into master Jun 14, 2024
40 of 41 checks passed
@mergify mergify bot deleted the allow-specifying-auto-config-path branch June 14, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FlowDB Issues related to FlowDB ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants