Tasks/946 remove file move ops #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linting issues due to previously not having the black pre-commit hook.
maxalbert
approved these changes
Jun 21, 2019
|
Hmm, codecov seems to be hanging with the code coverage report. I'm happy to merge this anyway because I think the coverage in flowetl should remain the same (if not, this can be amended in a subsequent PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #946
I have:
Description
This removes the
archive, dump, ingest, quarantinedirectories, adds a singlefilesdirectory instead and removes the file moving logic - the state is now solely tracked in the ETL records.