BUGFIX: Set up missing alias during node indexing #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command `nodeindex:build` does not set up aliases after creating fresh indexes until it considers the indexing complete. This is good, usually, since it allows for indexing "in the background". But if no aliases exist at all, this is going to break. This change fixes that by setting up aliases after creating (fresh) indexes, if no aliases exist. Fixes Flowpack#370
With this change running `nodeindex:indexnode` - without `--postfix` uses existing aliases or creates a new postfix (like `nodeindex:build` does) and sets up aliases - with `--postfix` given will use that postfix and not change aliases, as that's probably intended when passing the postfix manually Fixes Flowpack#370
|
Not sure about lower branches… I am quite certain I saw this issue on older versions, but don't have a project at hand right now to verify. Also older versions (of Elasticsearch) are EOL anyway. |
daniellienert
approved these changes
Feb 12, 2021
|
@daniellienert – You mentioned fixed tests on Slack, should that help with this PR? Any hints on what needs to be fixed? |
|
@kdambekalns rebase it in 7.0 should fix the Tests |
That was easy… now I just needed to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370