Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Replace hard coded ContextFactory references with the interface #381

Merged
merged 1 commit into from
Apr 13, 2021
Merged

BUGFIX: Replace hard coded ContextFactory references with the interface #381

merged 1 commit into from
Apr 13, 2021

Conversation

bwaidelich
Copy link
Contributor

@bwaidelich bwaidelich commented Apr 13, 2021 •
edited by kdambekalns
Loading

This replaces the use of the ContextFactory of the ContentRepository package in several places with the ContextFactoryInterface instead.

That fixes failures like

Call to undefined method Neos\ContentRepository\Domain\Service\Context::getCurrentSiteNode() [...]

when expecting a Neos context during indexing.

Fixes: #380

kdambekalns
kdambekalns approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for finding and fixing!

@daniellienert daniellienert merged commit 4620d60 into 7.0 Apr 13, 2021
@kdambekalns kdambekalns deleted the bugfix/380-replace-hardcoded-contextfactory branch May 4, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdambekalns kdambekalns kdambekalns approved these changes

@daniellienert daniellienert daniellienert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwaidelich @kdambekalns @daniellienert