BUGFIX: Keep fulltext index of hidden nodes as those may be searched in backend use cases #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in backend use cases The fulltext fields for hidden nodes previously were calculated but then not stored. This makes sense for removed nodes but hidden nodes exist and may be found by users that have the correct permissions.
|
This will probably need a rebase when accepted as lower branches are affected aswell. |
| @@ -126,7 +126,7 @@ public function fulltext(NodeInterface $node, array $fulltextIndexOfNode, string | |||
| ctx._source.neos_fulltext_parts = new HashMap(); | |||
| } | |||
|
|
|||
| if (params.nodeIsRemoved || params.nodeIsHidden || params.fulltext.size() == 0) { | |||
There was a problem hiding this comment.
If content from hidden nodes are added to the fulltext_parts, I assume they are automatically merged to the parent document where it is impossible to distinguish between content from hidden and not hidden node and the document would also be found by the originally hidden content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fulltext fields for hidden nodes previously were calculated but then not stored. This makes sense for removed nodes but hidden nodes exist and may be found by users that have the correct permissions.