BUGFIX: Use property mapping for type: SomeClass or array<SomeClass>
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebobo
reviewed
Jun 19, 2023
mhsdesign
changed the title
type: SomeClass or array<SomeClass>
jonnitto
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
I've tested it with https://github.com/jonnitto/Jonnitto.ImagesInARow and it works as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression in Version 2, due to accidental too strict handling ^^
solves: #61
This will allow property mapping in the following cases:
type: SomeClasstype: array<SomeClass>but we make sure to use strict property mapping, so in case there were any errors
PropertyMapper::getMessages()::hasErrors()we will log them as usual.The restrictions will prevent the property mapper turning a array into a string for example. For primitives, the given type must match as is.
References can still be set either by passing in a node object or its identifier (which must exist)