Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] RPG Loot: Revisited & READY #2886

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[MIRROR] RPG Loot: Revisited & READY #2886

merged 1 commit into from
Apr 15, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1985
Original PR: tgstation/tgstation#82533

About The Pull Request

Revival of #72881

A new alt click window with a tarkov-y loading spinner. Replaces the object item window in stat panel.

Videos

vids

toggleable grouping:
syAA5zf6RK

now lists the floor as first obj:
abc

in action:
dreamseeker_IkrPKt2QZt

features:

  • search by name
  • 515 image generator is much faster than alt click menu
  • opening a gargantuan amount of items shouldnt freeze your screen
  • groups similar items together in stacks by default, toggleable
  • shows tile as first item
  • Shift and Ctrl compatible with LMB 🖱️
  • RMB points points at items (sry i could not get MMB working)
  • key Esc to exit the window.

For devs:

  • A new image generation tech.
  • An error refetch mechanic to the Image component
  • It does not "smart track" the items being added to the pile, just reopen or refresh. This was a design decision.

Why It's Good For The Game

Honestly I just dislike the stat panel

Fixes #53824

Fixes
image

Changelog

🆑 jlsnow301
add: Added a loot window for alt-clicking tiles.
del: Removed the item browser from the stat panel.
/:cl:

* RPG Loot: Revisited & READY

* Update client_procs.dm

---------

Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com>
@mogeoko mogeoko merged commit 416a5b6 into master Apr 15, 2024
26 checks passed
@mogeoko mogeoko deleted the upstream-mirror-1985 branch April 15, 2024 20:00
AnywayFarus added a commit that referenced this pull request Apr 15, 2024
Iajret pushed a commit that referenced this pull request Jun 11, 2024
* Add mggaow, prbt and mrrp

* Reduced power level (volume) of mggaow

* Muzzle mggaow yet again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants