[MIRROR] Makes computer console circuits more consistent #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makes computer console circuits more consistent (#83412) ## About The Pull Request This PR makes the computer console's print feature work on a signal instead of wasting paper every string update, changes the flashlight color change to do the same, fixes the on/off signal not turning the console on, and fixes the signal for the console turning off not functioning. ## Why It's Good For The Game Besides the bug fixes, this makes the console components more consistent with every other circuit component. The refactor is to prevent worrying about nulls for colors or errors because of early returns. ## Changelog :cl: fix: computers with no lights can now turn on using the on/off signal fix: RGB lights on PDA circuits now use a signal fix: the is_off signal now works on consoles fix: printing text on a console component now uses a signal refactor: each input signal in console circuits now have their own proc /:cl: * Makes computer console circuits more consistent --------- Co-authored-by: Echriser <EthanSC2001@outlook.com> Co-authored-by: NovaBot13 <novasector13@gmail.com>
AnywayFarus
added a commit
that referenced
this pull request
May 28, 2024
Iajret
pushed a commit
that referenced
this pull request
Jul 4, 2024
…RE] (#3512) * Feast of Owls - new sound and chat messages change (#84342) ## About The Pull Request I originally made the sound effect to accompany heretic ascension announcements, but #82878 did that first (and even better, making unique ones for each path). I thought of ways to reuse it, perhaps replacing the heretic gain sound effect, since it uses the original sound in the background, but concluded that it's too intense for that. However, I think it could work for the feast ritual, being basically a more dramatic opening for the antag (I assume it would typically be performed near the shift's start). Also, the ritual is your reward for forsaking an ascension and thus playing an ascension theme, so I think it kind of makes sense to give it a unique sound effect as well... Here is the theme: https://github.com/tgstation/tgstation/assets/44502667/018a2e25-8956-4620-a4fb-ccdfdfdc82b4 Let me know if you like it, or whether it's too long for your taste or anything like that 😆. Since we're already at it, I also improved the ritual's presentation in chat (which I found quite underwhelming), giving it larger text, and a message akin to the ones gained from influences and the knowledge ritual. ## Why It's Good For The Game It's a somewhat impactful ritual, and I think it could use a theme. ## Changelog :cl: add: the Feast of Owls now leaves more dramatic messages in your chat sound: the Feast of Owls now has a little theme /:cl: * Feast of Owls - new sound and chat messages change --------- Co-authored-by: ViktorKoL <44502667+ViktorKoL@users.noreply.github.com> Co-authored-by: NovaBot13 <novasector13@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2690
Original PR: tgstation/tgstation#83412
About The Pull Request
This PR makes the computer console's print feature work on a signal instead of wasting paper every string update, changes the flashlight color change to do the same, fixes the on/off signal not turning the console on, and fixes the signal for the console turning off not functioning.
Why It's Good For The Game
Besides the bug fixes, this makes the console components more consistent with every other circuit component. The refactor is to prevent worrying about nulls for colors or errors because of early returns.
Changelog
🆑 Echriser
fix: computers with no lights can now turn on using the on/off signal
fix: RGB lights on PDA circuits now use a signal
fix: the is_off signal now works on consoles
fix: printing text on a console component now uses a signal
refactor: each input signal in console circuits now have their own proc
/:cl: