Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hue color edit filter #13

Closed
wants to merge 9 commits into from

Conversation

vaderdan
Copy link

@muukii 😉

#8

@muukii
Copy link
Collaborator

muukii commented Nov 15, 2018

@vaderdan
I was not able to find ColorControl.swift in this PR.
How can I see it?

@vaderdan
Copy link
Author

@muukii sorry I forgot to add it

@vaderdan vaderdan changed the title add hue color edit filter WIP: add hue color edit filter Nov 15, 2018
@vaderdan vaderdan changed the title WIP: add hue color edit filter add hue color edit filter Nov 15, 2018
@muukii
Copy link
Collaborator

muukii commented Nov 15, 2018

@vaderdan
Okay, Thank you.
I'll check this with launching demo application.

I think using CIHueAdjustment is better named as HueControl.
Because Color means highlight-tint and shadow-tint on Instagram.

And HSL I said is meaning following control.
screen shot 2018-11-16 at 1 11 04

I think that will need some shaders.

@muukii
Copy link
Collaborator

muukii commented Nov 15, 2018

But, the code you write is pretty good.

@muukii
Copy link
Collaborator

muukii commented Nov 15, 2018

Firstly, I think I want to add only the code of PixelEngine layer.
Next, We need to think about name of control and icon.
About icon, our designer will create that.

@vaderdan
Copy link
Author

vaderdan commented Nov 15, 2018

What do you mean shaders metal or opengl or custom CImage filter
http://flexmonkey.blogspot.com/2016/03/creating-selective-hsl-adjustment.html

what do you think about the link

@muukii
Copy link
Collaborator

muukii commented Nov 15, 2018

@vaderdan
Sorry
shader which means shader with Metal Shading Language.
Instagram does not have that feature.
Instead, VSCO has one. HSL

Color should be this control.
original
We already have the code for this.
https://github.com/muukii/Pixel/blob/master/From%20Fil/FilterHighlightShadowTint.swift
But it does not have UI.

@vaderdan vaderdan changed the title add hue color edit filter WIP: add hue color edit filter Nov 16, 2018
}
}

override public func draw(_ rect: CGRect) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thank you for your implementation.

I think using CAShapeLayer will be better than drawing.
Because CAShapeLayer can animate.

CoreCircle : CAShapeLayer
SelectingBorderCircle: CAShapeLayer

What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll do that, I'll try to get them animated in another pull request

@vaderdan vaderdan changed the title WIP: add hue color edit filter add hue color edit filter Dec 29, 2018
@muukii muukii closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants