-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hue color edit filter #13
Conversation
@vaderdan |
@muukii sorry I forgot to add it |
@vaderdan I think using And HSL I said is meaning following control. I think that will need some shaders. |
But, the code you write is pretty good. |
Firstly, I think I want to add only the code of PixelEngine layer. |
What do you mean shaders metal or opengl or custom CImage filter what do you think about the link |
@vaderdan Color should be this control. |
} | ||
} | ||
|
||
override public func draw(_ rect: CGRect) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Thank you for your implementation.
I think using CAShapeLayer will be better than drawing.
Because CAShapeLayer can animate.
CoreCircle : CAShapeLayer
SelectingBorderCircle: CAShapeLayer
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'll do that, I'll try to get them animated in another pull request
@muukii 😉
#8