Multi-channel output for the CoreAudio driver. #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't use macOS anymore. My MBP is useless after the update to Catalina, so I'm planning to install Linux on it. Bye, bye, Apple! |
…re more outputs than specified in the channel map. FluidSynth#1081 (comment)
…p setting documentation to be consistent with other entries.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pull request does two things:
Enable the synth.audio-channels and synth.audio-groups settings to work with CoreAudio as they do on other platforms.
AudioStreamBasicDescription, which was hardcoded as interleaved stereo. A nice efficiency improvement we can make here is adding thekAudioFormatFlagIsNonInterleavedflag, which allows us to skip the allocation and interleave + copy step and pass the buffers filled by the fluidsynth render callback directly.Adds a audio.coreaudio.channel-map setting to make use of CoreAudio's standard channel mapping facility to arbitrarily route output channels.
As an example of why these changes are helpful, I use them for live performances to route MIDI instruments, samples, and cues to different channels on a digital rack mixer where they can be adjusted by a front-of-house sound engineer as if they were separate instruments.