Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit declaration of function strcasecmp with musl #1244

Closed

Conversation

listout
Copy link

@listout listout commented May 11, 2023

No description provided.

@listout listout force-pushed the implicit-declaration-fix-musl branch from c237486 to d4aa950 Compare May 11, 2023 17:47
@derselbst
Copy link
Member

Well yeah, that's the same fix as mine in 0b40da5 . I would be more interested in a way to reproduce this build failure in a CI pipeline, particularly in #1243. But the Alpine build succeeds there: https://dev.azure.com/tommbrt/tommbrt/_build/results?buildId=9127

I don't see how the question of C99 compliance is relevant here, esp. because fluidsynth is a C89 project currently.

@listout
Copy link
Author

listout commented May 11, 2023

I don't see how the question of C99 compliance is relevant here, esp. because fluidsynth is a C89 project currently.

You're correct, by bad. Let me correct that.

I don't see how the question of C99 compliance is relevant here, esp. because fluidsynth is a C89 project currently.

THe issue was reproduced on Gentoo with musl libc. https://bugs.gentoo.org/906150. I don't know if alpine is doing something special.

@derselbst
Copy link
Member

Ok, thanks for the pointer. I'll double check any compiler flags with the apline build when I find the time.

According to #1229 this is a problem on Alpine as well, but this issue lacks precise instructions on reproducing it.

CMakeLists.txt Outdated
@@ -159,6 +159,7 @@ include ( CheckIncludeFile )
include ( CheckSymbolExists )
include ( CheckTypeSize )
check_include_file ( string.h HAVE_STRING_H )
check_include_file ( string.h HAVE_STRINGS_H )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be strings.h

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, thanks

Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
@listout listout force-pushed the implicit-declaration-fix-musl branch from d4aa950 to 5d7dfbf Compare May 12, 2023 02:09
@derselbst
Copy link
Member

Superseded by #1245

@derselbst derselbst closed this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants