implement 24 bit sample support for fluid_voice_optimize_sample() #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjceresa
reviewed
Jan 20, 2018
| */ | ||
| #define FLUID_NOISE_FLOOR 0.00003 | ||
| #define FLUID_NOISE_FLOOR 2.e-7 | ||
|
|
||
|
|
There was a problem hiding this comment.
On 24 bits the noise is -(144 - 6) = -138 dB. So noise floor amplitude = is 10^(-138/20) = 1.26e-7. Saying that we could keep 2.e-7. :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to #301,
fluid_voice_optimize_sample()should calculate the noise floor using 24 bit samples as well. Otherwise very quiet voices could be turned off too early.@mawe42 Do you agree with
FLUID_NOISE_FLOOR?