Convex shape for modEnv #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, i will look and add the adequate handling, during the next days,weeks! |
|
Ok, no hurry. I've scheduled this for 2.1, so we have plenty of time. |
- this insures seamless pitch and filter frequency cutoff transition.
|
Commit 8d8e7ec is a complement related to the convex
Ok. Reversely handling when skipping from a section above |
Since v 2.1 ,as recommended by soundfont 2.01/2.4 spec ATTACK section is convex. So, when skiping from a section above ATTACK to ATTACK, it is necessary to correct current modulation envelope value to get seamless transition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the convex shape of modEnvAttack as per soundfont spec.
Tested with the data set by @mrbumpy409 in issue #153. First picture shows the spectrogram of the audigy's version, second is the new convex version of fluidsynth. (Previously it was linear.)
@jjceresa Could you please look into correct handling during legato playing, such as in
fluid_rvoice_multi_retrigger_attack()?Fixes #153.