Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fluidsynth calling ipatch_close() #644

Merged
merged 4 commits into from
May 2, 2020
Merged

Make fluidsynth calling ipatch_close() #644

merged 4 commits into from
May 2, 2020

Conversation

jjceresa
Copy link
Collaborator

@jjceresa jjceresa commented May 1, 2020

This should address issue #643

Warning: this works only if swami/libinstpatch#47 is applied, otherwise Swami will fail with memory violation.

@derselbst
Copy link
Member

Technically, this change would have required bumping the minimum required libinstpatch version. To avoid that, I've made it backward compatible and added the missing call to ipatch_init() into new_fluid_synth().

@jjceresa
Copy link
Collaborator Author

jjceresa commented May 2, 2020

I've made it backward compatible.

Thanks !

@derselbst derselbst merged commit 8a3eaf9 into master May 2, 2020
@derselbst derselbst deleted the instpatch-deint branch May 2, 2020 12:31
@jjceresa
Copy link
Collaborator Author

jjceresa commented May 2, 2020

Just tried current fluidsynth master with current libinspatch and current swami. This works. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants