Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the MIDI file player restart on-demand #755

Closed
wants to merge 1 commit into from
Closed

Allow the MIDI file player restart on-demand #755

wants to merge 1 commit into from

Conversation

rncbc
Copy link
Contributor

@rncbc rncbc commented Jan 26, 2021

Resets the default sample timer properly, allowing the internal
MIDI file player to restart its playlist on any other time but
the initial first.

Lets Qsynth play any MIDI files that are drag-n-dropped, anytime
after the first, following synth engine initialization.

Resets the default sample timer properly, allowing the internal
MIDI file player to restart its playlist on any other time but
the initial first.

Lets Qsynth play any MIDI files that are drag-n-dropped, anytime
after the first, following synth engine initialization.
Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. Will be part of 2.1.7 which I'll be releasing upcoming weekend.

@derselbst derselbst added the bug label Jan 27, 2021
@derselbst derselbst added this to the 2.1 milestone Jan 27, 2021
@rncbc rncbc requested a review from derselbst January 27, 2021 22:57
derselbst pushed a commit that referenced this pull request Jan 28, 2021
Resets the default sample timer properly, allowing the internal
MIDI file player to restart its playlist on any other time but
the initial first.

Lets Qsynth play any MIDI files that are drag-n-dropped, anytime
after the first, following synth engine initialization.
derselbst pushed a commit that referenced this pull request Jan 28, 2021
Resets the default sample timer properly, allowing the internal
MIDI file player to restart its playlist on any other time but
the initial first.

Lets Qsynth play any MIDI files that are drag-n-dropped, anytime
after the first, following synth engine initialization.
@derselbst
Copy link
Member

Cherry-picked to 2.1.x branch

@derselbst derselbst closed this Jan 29, 2021
jet2jet pushed a commit to jet2jet/fluidsynth-emscripten that referenced this pull request May 27, 2021
Resets the default sample timer properly, allowing the internal
MIDI file player to restart its playlist on any other time but
the initial first.

Lets Qsynth play any MIDI files that are drag-n-dropped, anytime
after the first, following synth engine initialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants