WASAPI driver reorganization #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aller process context
derselbst
reviewed
Apr 10, 2021
There was a problem hiding this comment.
Ok, this looks pretty good already. Thank you! I have two points:
- The unit tests are failing. For a possible reason, see below.
new_fluid_wasapi_audio_driver2should wait until the synth thread has finished basic initialization, before returning the audio driver to the caller. On my laptop, WASAPI always fails because the default sample rate 44.1 khz is not supported by my soundcard. Previously, fluidsynth was exiting correctly with error. Now, it just stays open doing nothing. So, if the synth thread fails before it enters thefor(;;)loop,new_fluid_wasapi_audio_driver2should return NULL.
fixed new_fluid_wasapi_audio_driver2 waiting until the initialization or the synthesis thread has finished
derselbst
reviewed
Apr 12, 2021
…imeout for the start event to 1000 ms
…e wait timeout for the start event to 1000 ms" This reverts commit 81c139c.
derselbst
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
derselbst
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid initializing COM in the caller's thread context.
See also: #833