Skip to content

Commit

Permalink
[TASK] Rename getArguments to getMenuArguments
Browse files Browse the repository at this point in the history
The name getArguments will be reserved in Fluid 3.0.
  • Loading branch information
NamelessCoder committed Oct 10, 2019
1 parent 4d62d39 commit fa67db1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Classes/ViewHelpers/Menu/AbstractMenuViewHelper.php
Expand Up @@ -602,7 +602,7 @@ protected function retrieveReconfiguredParentMenuInstance($pageUid)
return null;
}
$parentInstance = $this->renderingContext->getViewHelperVariableContainer()->get(AbstractMenuViewHelper::class, 'parentInstance');
$arguments = $parentInstance->getArguments();
$arguments = $parentInstance->getMenuArguments();
$arguments['pageUid'] = $pageUid;
$parentInstance->setArguments($arguments);

Expand All @@ -627,7 +627,7 @@ protected function cleanTemplateVariableContainer()
/**
* @return array
*/
public function getArguments()
public function getMenuArguments()
{
if (false === is_array($this->arguments)) {
return $this->arguments->toArray();
Expand Down
2 changes: 1 addition & 1 deletion Classes/ViewHelpers/Menu/SubViewHelper.php
Expand Up @@ -43,7 +43,7 @@ public function render()
if (null === $parentInstance) {
return null;
}
$parentArguments = $parentInstance->getArguments();
$parentArguments = $parentInstance->getMenuArguments();
$isActive = $this->pageService->isActive($pageUid);
// Note about next case: although $isCurrent in most cases implies $isActive, cases where the menu item
// that is being rendered is in fact the current page but is NOT part of the rootline of the menu being
Expand Down

0 comments on commit fa67db1

Please sign in to comment.