Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21 #22

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Fix #21 #22

merged 2 commits into from
Sep 8, 2020

Conversation

nekocode
Copy link
Contributor

@nekocode nekocode commented Sep 8, 2020

What does this change?

Fix the issue #21

@nekocode nekocode changed the title Patch 1 Fix #21 Sep 8, 2020
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #22 into main will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   93.87%   93.93%   +0.06%     
==========================================
  Files          15       15              
  Lines         359      363       +4     
==========================================
+ Hits          337      341       +4     
  Misses         22       22              
Impacted Files Coverage Δ
lib/src/settings/flutter.dart 100.00% <100.00%> (ø)
lib/src/settings/flutter_gen.dart 95.45% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40ab36...2552aca. Read the comment docs.

@nekocode
Copy link
Contributor Author

nekocode commented Sep 8, 2020

Hi @wasabeef . There is a bug in the config parsing: the hasIntegrations and hasColors will always return true in some cases. This PR fixes it.

I added some code to the unit-tests. You can pull this patch branch, reset to the commit 90c132e47e2bdb7635916953b63f80942b4f1aa0 and run unit-test to reproduce the bug.

@wasabeef wasabeef added this to the 1.0.1 milestone Sep 8, 2020
@wasabeef
Copy link
Member

wasabeef commented Sep 8, 2020

@nekocode
Thank you :shipit:
The NoSuchException didn't happen on my macos, so the check was missing.

@wasabeef wasabeef merged commit 905324e into FlutterGen:main Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants