-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor config parser with json_serialization #76
Conversation
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 99.34% 98.11% -1.24%
==========================================
Files 17 16 -1
Lines 458 477 +19
==========================================
+ Hits 455 468 +13
- Misses 3 9 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this change?
pubspec.yaml
into a default config before parsing, so we don't need to handle null case.PS
We can not use
build_runner
directly inside a builder project.So we need to create another project (_internal) for running
build_runner
.See: #dart-lang/build#2982
What is the value of this and can you measure success?
Pass test