support multiple batch dimensions in Dense layer

[CarloLucibello]

Since most deep learning frameworks support it, we also should.

I can't find a corresponding issue. #282 is slightly related.
After this, we should close #708

PR Checklist

• Tests are added
• Entry in NEWS.md
• Documentation, if applicable
• Final review from @dhairyagandhi96 (for API changes).

[DhairyaLGandhi]

Is this doing the correct thing here?

[CarloLucibello]

what do you mean? it does what is meant to do. Pytorch does the same thing.
Notice that this is not #282 or #856

[mcabbott]

+1, this seems like the obvious behaviour.

I'd be tempted to make the existing method x::AbstractVecOrMat and then have x::AbstractArray which reshapes & calls that. But not a huge deal.

[CarloLucibello]

I'd be tempted to make the existing method x::AbstractVecOrMat and then have x::AbstractArray which reshapes & calls that. But not a huge deal.

yeah, I didn't do it because the performance impact is negligible in any case, but we could. Anyway, as you said not a big deal

[DhairyaLGandhi]

bors r+

[CarloLucibello]

If we want to strictly adhere to ColPrac (and maybe we don't ), you should just approve Prs from collaborators with merge rights, then they merge by themselves:

Reviewing, Approving and Merging PRs

• PRs must have 1 approval before they are merged.
• PR authors should not approve their own PRs.
• PRs should pass CI tests before being merged.
• PRs by people without merge rights must have approval from someone who has merge rights (who will usually then merge the PR).
• PRs by people with merge rights must have approval from someone else, who may or may not have merge rights (and then may merge their own PR).
• PRs by people with merge rights should not be merged by people other than the author (just approved).

[DhairyaLGandhi]

you should be able to use bors like usual

[CarloLucibello]

you should be able to use bors like usual

sure, but I think that you need to hit Approve in Github's review (according to ColPrac)

[DhairyaLGandhi]

bors r+

[bors]

Build succeeded:

• ci/gitlab/gitlab.com