Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few sanity checks #1409

Closed
wants to merge 3 commits into from
Closed

Add a few sanity checks #1409

wants to merge 3 commits into from

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Nov 27, 2020

This adds a warning if your Chain gets a Float64 gradient, as that's an easy way to get awful performance. Done in a much tidier way than #1031.

And errors on wrong-length loadparams! / restructure, closes #1408.

Has a test for #1393, too, which will fail until that's merged. Or can be moved, but simplest to merge that first.

@mcabbott mcabbott mentioned this pull request Nov 27, 2020
4 tasks
@mcabbott mcabbott closed this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No sanity checks on destructure and loadparams!
1 participant