Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metalhead integration #206

Closed
wants to merge 9 commits into from
Closed

Conversation

ablaom
Copy link
Collaborator

@ablaom ablaom commented Jun 23, 2022

To close #205 and #162.

Does not need FluxML/Metalhead.jl#176 but includes a temporary hack that can be removed when that is resolved. This PR defines a generic image_builder(Constructor) wrapper, but this won't work as advertised (and cannot be made public) until FluxML/Metalhead.jl#176 is resolved.

WIP. See the image_builder docstring for more details.

Todos (incomplete):

  • Add catch for disallowed kwargs in metal(Constructor)(args..., kwargs...)
  • Add show method for the wrappers

@ablaom ablaom marked this pull request as draft June 23, 2022 20:07
@codecov-commenter
Copy link

Codecov Report

Merging #206 (64f9b3d) into dev (b3fa3a8) will decrease coverage by 3.18%.
The diff coverage is 63.33%.

@@            Coverage Diff             @@
##              dev     #206      +/-   ##
==========================================
- Coverage   92.27%   89.09%   -3.19%     
==========================================
  Files           9       10       +1     
  Lines         246      275      +29     
==========================================
+ Hits          227      245      +18     
- Misses         19       30      +11     
Impacted Files Coverage Δ
src/builders.jl 100.00% <ø> (ø)
src/metalhead.jl 62.06% <62.06%> (ø)
src/types.jl 85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fa3a8...64f9b3d. Read the comment docs.

@ablaom
Copy link
Collaborator Author

ablaom commented Jun 28, 2022

Closed in favour of #208

@ablaom ablaom closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Metalhead "builders" into MLJFlux
2 participants