Throw an error when encountering missing values #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 74.68% 74.75% +0.06%
==========================================
Files 9 9
Lines 403 404 +1
==========================================
+ Hits 301 302 +1
Misses 102 102
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JET.jl rightly notes that this function will error if a
missingappears inside an expression, and we try to bind it. This is certainly an edge case (and clearly no-one's hit it so far), but strictly speakingmissingis allowed inExprs, and the internal error isn't ideal if someone does hit it. So I've added an explicit error. In future we could add support (probably by assumingmissing == missingfor the purposes of this check).Separately: unfortunately, JET/Julia's inference isn't smart enough to figure out that the missing-boolean error no longer applies. Is there some way to assert that
env[name]::!Missing, ie anything other than missing? A type assert would be ok, but I'd be a bit reluctant to do anything more complex that sacrifices readability.