Fix tests on 1.8 #128
Merged
Fix tests on 1.8 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2898925212
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 70.67% 71.38% +0.70%
==========================================
Files 9 9
Lines 648 657 +9
==========================================
+ Hits 458 469 +11
+ Misses 190 188 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
If you're running tests with >1 threads, that's a long-standing NNlib issue and I'm not sure where it comes from :( |
ToucheSir
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #125, this replaces the method definitions for
catfunctions with slightly less crazy loops, which have fewer ambiguities. In anycat(A,B,Cs...), one of the first two must be a tracked type, no longer one of the first 3, as this shortens the list.The other failure was
depthwiseconv. This is depends on the random number seed, it doesn't consistently fail, I have not investigated whether this is a numerical problem or a gradient problem.