[Merged by Bors] - Another Bijectors.jl compat bound bump #457
Conversation
|
Tests are failing because we're now (for some reason) using Tracker@0.2.23 instead of Tracker@0.2.20 (which we were using in the old tests). @devmotion I see you've made the majority of the contributions to Tracker.jl between these two versions; do you see what could be causing the issue? |
|
Having had a look at some of the discussion, it seems 0.2.20 shouldn't be used anyways. It seems as if, somehow, https://github.com/TuringLang/DistributionsAD.jl/blob/c30bcd993e5a0f0cdb56336c5e4a18cb63f198f9/src/tracker.jl#L143-L146 ends up pulling back a |
|
Based on FluxML/Tracker.jl@v0.2.20...v0.2.23, maybe the clean-up in FluxML/Tracker.jl#128 causes some issues? |
Pull Request Test Coverage Report for Build 4137072991
💛 - Coveralls |
Codecov ReportBase: 74.39% // Head: 74.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #457 +/- ##
==========================================
+ Coverage 74.39% 74.42% +0.03%
==========================================
Files 20 20
Lines 2445 2444 -1
==========================================
Hits 1819 1819
+ Misses 626 625 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was indeed the issue. The problem was that I confused myself and wrote:
which was in fact the opposite of what I should have been saying, i.e. it's working on 0.2.23 not 0.2.20 😅 I added a compat bound for tests and Tracker so we should be good now. |
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
…eep existing compat) (#469) * Fixed a typo in tutorial (#451) * CompatHelper: bump compat for Turing to 0.24 for package turing, (keep existing compat) (#450) This pull request changes the compat entry for the `Turing` package from `0.21` to `0.21, 0.24` for package turing. This keeps the compat entries for earlier versions. Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request. Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> * Some minor utility improvements (#452) This PR does the following: - Moves the `varname_leaves` from `TestUtils` to main module. - It can be very useful in Turing.jl for constructing `Chains` and the like, so I think it's a good idea to make it part of the main module rather than keeping it "hidden" there. - Makes the default `varinfo` in the constructor of `LogDensityFunction` be `model.context` rather than a new `DynamicPPL.DefaultContext`. - The `context` pass to `evaluate!!` will override the leaf-context in `model.context`, and so the current default constructor always uses `DefaultContext` as the leaf-context, even if the `Model` has been `contextualize`d with some other leaf-context, e.g. `PriorContext`. This PR fixes this issue. * Always run CI (#453) I find the current `bors` workflow a bit tedious. Most of the time, I summon `bors` to see the CI results (see e.g. #438). Given that most `CI` tests are quick (< 10mins), we can always run them by default. The most time-consuming `IntegrationTests` is still run by `bors` to avoid excessive CI runs. * Compat with new Bijectors.jl (#454) This PR makes DPPL compatible with the changes to come in TuringLang/Bijectors.jl#214. Tests are passing locally. Closes #455 Closes #456 * Another Bijectors.jl compat bound bump (#457) * CompatHelper: bump compat for MCMCChains to 6 for package test, (keep existing compat) (#467) This pull request changes the compat entry for the `MCMCChains` package from `4.0.4, 5` to `4.0.4, 5, 6` for package test. This keeps the compat entries for earlier versions. Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request. Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> * CompatHelper: bump compat for AbstractPPL to 0.6 for package test, (keep existing compat) --------- Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com> Co-authored-by: github-actions[bot] <compathelper_noreply@julialang.org> Co-authored-by: Tor Erlend Fjelde <tor.erlend95@gmail.com>
Attempt at addressing #461. I think the approach here is somewhat correct, but it's currently very dirty because of the intricacies of `VarInfo` implementation. This can be cleaned up, but will take some effort. Until I've done this, I leave this as a draft PR. We also most certainly need to do some benchmarking before merging this as it could lead to some additional overhead. NOTE: This is based on #457 Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
No description provided.