Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve adjoint for product and zip #1489

Merged
merged 16 commits into from
Jan 19, 2024
Merged

Improve adjoint for product and zip #1489

merged 16 commits into from
Jan 19, 2024

Commits on Jan 17, 2024

  1. initial commit

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9914d59 View commit details
    Browse the repository at this point in the history

  2. add adjoint for collect ProductIterator

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    4616eaf View commit details
    Browse the repository at this point in the history

  3. tests and fixes for collect adjoint

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a88bb3f View commit details
    Browse the repository at this point in the history

  4. rebase and make dims a tuple again

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3ac1fb8 View commit details
    Browse the repository at this point in the history

  5. Update src/lib/array.jl 

    Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
    @lxvm @ToucheSir
    lxvm and ToucheSir committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8903ed4 View commit details
    Browse the repository at this point in the history

  6. rename productfunc

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ab95858 View commit details
    Browse the repository at this point in the history

  7. update adjoints for zip

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1a4b275 View commit details
    Browse the repository at this point in the history

  8. typo

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c9f222c View commit details
    Browse the repository at this point in the history

  9. inference tests for product

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2efd29d View commit details
    Browse the repository at this point in the history

  10. add tests for zip

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    4e36d7b View commit details
    Browse the repository at this point in the history

  11. better pullback names

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8adfd29 View commit details
    Browse the repository at this point in the history

  12. rewrite unnecesarily generated function

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3087003 View commit details
    Browse the repository at this point in the history

  13. restore arrays with nothing elements

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2bf7633 View commit details
    Browse the repository at this point in the history

  14. update zip test for nothings

    @lxvm
    lxvm committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    734a6c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Apply suggestions from code review 

    Remove `Val` from `ntuple`s where constant propagation occurs

Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
    @lxvm @ToucheSir
    lxvm and ToucheSir committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    8c61928 View commit details
    Browse the repository at this point in the history

  2. use number as sentinel

    @lxvm
    lxvm committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    18e48db View commit details
    Browse the repository at this point in the history