basic sparse handling #762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be closed in favour of JuliaDiff/ChainRules.jl#246? |
DhairyaLGandhi
commented
Dec 23, 2020
|
bors r+ Let's also add the corresponding changes in ChainRules, but I think we have some work looking to use sparse handling currently, and we can dd it to the list of things we have to move. |
|
bors r- Reviews 👍 |
|
Canceled. |
added 2 commits
December 23, 2020 19:10
DhairyaLGandhi
commented
Dec 23, 2020
willtebbutt
approved these changes
Dec 23, 2020
DhairyaLGandhi
commented
Dec 23, 2020
|
That small difference would cause weird issues with |
| @test gradtest(x -> sum(sparse(x)), rand(Float32, 3,3)) | ||
| @test gradtest(x -> sum(sparse(x)), rand(Float32, 3)) # test vectors also | ||
| @test gradcheck(x -> sum(diagm(x)), sparse(rand(3))) | ||
| end |
There was a problem hiding this comment.
can add a test for broadcasting
| @@ -2,6 +2,8 @@ using Zygote, Test, Random, LinearAlgebra, Statistics, FillArrays, | |||
| AbstractFFTs, FFTW, Distances | |||
| using Zygote: gradient | |||
| using Base.Broadcast: broadcast_shape | |||
| using Distributed: pmap | |||
|
a test is failing |
|
Actually, I see you also filed JuliaDiff/ChainRules.jl#246, can we close this PR in favor of that? |
|
Closing since this has been superseded by JuliaDiff/ChainRules.jl#579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #570, SciML/DifferentialEquations.jl#649, #742