Skip to content

Commit

Permalink
fix: update tests for object ids
Browse files Browse the repository at this point in the history
ref: #96
  • Loading branch information
FlxPeters committed Feb 26, 2023
1 parent 2a47a97 commit 33fe7b1
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions netbox_prometheus_sd/tests/test_serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def test_vm_minimal_to_target(self):
data = PrometheusVirtualMachineSerializer(instance=instance).data

self.assertEqual(data["targets"], ["vm-01.example.com"])
self.assertDictContainsSubset({"__meta_netbox_id": instance.id}, data["labels"])
self.assertDictContainsSubset({"__meta_netbox_id": str(instance.id)}, data["labels"])
self.assertDictContainsSubset(
{"__meta_netbox_model": "VirtualMachine"}, data["labels"]
)
Expand All @@ -35,7 +35,7 @@ def test_vm_full_to_target(self):
data = PrometheusVirtualMachineSerializer(instance=instance).data

self.assertEqual(data["targets"], ["vm-full-01.example.com"])
self.assertDictContainsSubset({"__meta_netbox_id": instance.id}, data["labels"])
self.assertDictContainsSubset({"__meta_netbox_id": str(instance.id)}, data["labels"])
self.assertDictContainsSubset(
{"__meta_netbox_model": "VirtualMachine"}, data["labels"]
)
Expand Down Expand Up @@ -110,7 +110,7 @@ def test_device_minimal_to_target(self):
data = PrometheusDeviceSerializer(instance=instance).data

self.assertEqual(data["targets"], ["firewall-01"])
self.assertDictContainsSubset({"__meta_netbox_id": instance.id}, data["labels"])
self.assertDictContainsSubset({"__meta_netbox_id": str(instance.id)}, data["labels"])
self.assertDictContainsSubset({"__meta_netbox_model": "Device"}, data["labels"])
self.assertDictContainsSubset(
{"__meta_netbox_role": "Firewall"}, data["labels"]
Expand All @@ -134,7 +134,7 @@ def test_device_full_to_target(self):
data = PrometheusDeviceSerializer(instance=instance).data

self.assertEqual(data["targets"], ["firewall-full-01"])
self.assertDictContainsSubset({"__meta_netbox_id": instance.id}, data["labels"])
self.assertDictContainsSubset({"__meta_netbox_id": str(instance.id)}, data["labels"])
self.assertDictContainsSubset({"__meta_netbox_model": "Device"}, data["labels"])
self.assertDictContainsSubset(
{"__meta_netbox_platform": "Junos"}, data["labels"]
Expand Down Expand Up @@ -168,7 +168,7 @@ def test_ip_minimal_to_target(self):
data = PrometheusIPAddressSerializer(instance=instance).data

self.assertEqual(data["targets"], ["10.10.10.10"])
self.assertDictContainsSubset({"__meta_netbox_id": instance.id}, data["labels"])
self.assertDictContainsSubset({"__meta_netbox_id": str(instance.id)}, data["labels"])
self.assertDictContainsSubset(
{"__meta_netbox_status": "active"}, data["labels"]
)
Expand All @@ -187,7 +187,7 @@ def test_ip_full_to_target(self):
["foo.example.com"],
"IP with DNS name should use DNS name as target",
)
self.assertDictContainsSubset({"__meta_netbox_id": instance.id}, data["labels"])
self.assertDictContainsSubset({"__meta_netbox_id": str(instance.id)}, data["labels"])
self.assertDictContainsSubset(
{"__meta_netbox_status": "active"}, data["labels"]
)
Expand Down

0 comments on commit 33fe7b1

Please sign in to comment.