Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gnome 44 #94

Closed
jumpyvi opened this issue Mar 28, 2023 · 18 comments
Closed

Support gnome 44 #94

jumpyvi opened this issue Mar 28, 2023 · 18 comments

Comments

@jumpyvi
Copy link

jumpyvi commented Mar 28, 2023

Gnome 44 should be supported.
I get GSettings schema org.gnome.shell.overrides not found as an error.

Gnome 44.0 on opensuse TW

@zeropoint46
Copy link

zeropoint46 commented Mar 31, 2023

I fixed this by updating metadata.json and adding "44.0" into the shell-version array. Then I had to edit extension.js and comment out line 871, 882, 918 and 925. Those didn't work for me on Fedora 38/Gnome 44, guess they are deprecated, not sure why but I didn't spend much time looking into it once it worked. Hope that help.

Here are the lines I commented:

   871  //              let shellSettings = new Gio.Settings({ schema_id: 'org.gnome.shell.overrides' });
   882  //              shellSettings.set_boolean("edge-tiling", false);
   918  //              let shellSettings = new Gio.Settings({ schema_id: 'org.gnome.shell.overrides' });
   925  //              shellSettings.reset("edge-tiling");

@Fmstrat
Copy link
Owner

Fmstrat commented Mar 31, 2023

Thanks, I will take a look this weekend. I also hope to add Wayland support as I do.

@zeropoint46
Copy link

sound good, thanks. Not sure I understand your wayland comment, however I'm currently running Gnome on wayland natively and wintile is working with those fixes.

@Fmstrat Fmstrat closed this as completed Apr 21, 2023
@zeropoint46
Copy link

@Fmstrat thanks for pushing a new release, I really appreciate it and the work you did. However, it seems that version 44 is missing in the metadata.json. So I think technically the latest release you just pushed still doesn't support gnome 44.

@Fmstrat
Copy link
Owner

Fmstrat commented Apr 21, 2023

@zeropoint46 Doh. v9 incoming.

@Fmstrat
Copy link
Owner

Fmstrat commented Apr 21, 2023

@zeropoint46 if you have problems with the error above still, let me know. I don't have 44 installed so can't validate that other PRs correct and/or interfere. If there is still an issue, I'll take a look at it personally afterwards. Thanks!

@jumpyvi
Copy link
Author

jumpyvi commented Apr 21, 2023

if you have problems with the error above still, let me know. I don't have 44 installed so can't validate that other PRs correct and/or interfere. If there is still an issue, I'll take a look at it personally afterwards. Thanks!

The same problem occurs on V9, GSettings schema org.gnome.shell.overrides not found. (Fedora 38)

@Fmstrat Fmstrat reopened this Apr 21, 2023
@Fmstrat
Copy link
Owner

Fmstrat commented Apr 21, 2023

Reopening.

@GrylledCheez
Copy link
Collaborator

GrylledCheez commented Apr 21, 2023

Can we not just use greater than?

const Config = imports.misc.config;
const [major, minor] = Config.PACKAGE_VERSION.split('.').map(s => Number(s));
major >= 40

@c0state
Copy link

c0state commented Apr 23, 2023

The same problem occurs on V9, GSettings schema org.gnome.shell.overrides not found. (Fedora 38)

Tiling assistant seems to have the same issue. They added a guard here it looks like?
https://salsa.debian.org/gnome-team/shell-extensions/gnome-shell-extension-tiling-assistant/-/compare/a762ec1ae84f174a3802e8d216d88d4f700f97a2...debian%2Fmain?from_project_id=64661&straight=false#6961099c5b4fb26eb6d87d27b0123a002ae596be_0_164

Not familiar enough with gnome-shell, but removing the 4 lines referencing shellSettings (https://github.com/Fmstrat/wintile/blob/master/extension.js#L885) in my local Ubuntu 23.04 install (GNOME Shell 44.0) seems to work.

edit: just realized #94 (comment) was saying basically the same thing

@SOSANA
Copy link

SOSANA commented Apr 25, 2023

I fixed this by updating metadata.json and adding "44.0" into the shell-version array. Then I had to edit extension.js and comment out line 871, 882, 918 and 925. Those didn't work for me on Fedora 38/Gnome 44, guess they are deprecated, not sure why but I didn't spend much time looking into it once it worked. Hope that help.

Here are the lines I commented:

   871  //              let shellSettings = new Gio.Settings({ schema_id: 'org.gnome.shell.overrides' });
   882  //              shellSettings.set_boolean("edge-tiling", false);
   918  //              let shellSettings = new Gio.Settings({ schema_id: 'org.gnome.shell.overrides' });
   925  //              shellSettings.reset("edge-tiling");

I have both Ubuntu 23.04 and fedora dual boot installed both having issues. I'm about to try your recommendations on Ubuntu first. But as of right now no way to get same suggested changes to work on fedora 38?

Also curious why this project isn't maintained as this is my favorite extension and been using it forever. Will they not allow others to do pull request or hand out off to someone who will maintain this?

@zeropoint46
Copy link

zeropoint46 commented Apr 25, 2023

@SOSANA not sure what you mean by:

"But as of right now no way to get same suggested changes to work on fedora 38?".

I have commented those lines and I'm on F38 with Gnome 44 and its working just fine for me.

@SOSANA
Copy link

SOSANA commented Apr 25, 2023

@SOSANA not sure what you mean by:

"But as of right now no way to get same suggested changes to work on fedora 38?".

I have commented those lines and I'm on F38 with Gnome 44 and its working just fine for me.

I missed read what you wrote, thought you were saying that it worked on ubuntu gnome 44 but not fedora 38 gnome 44 for some reason. Thanks for the clarification

@zeropoint46
Copy link

@SOSANA not sure why, I didn't mention ubuntu at all, as I don't use it, but glad you got it now.

@SOSANA
Copy link

SOSANA commented Apr 25, 2023

@SOSANA not sure why, I didn't mention ubuntu at all, as I don't use it, but glad you got it now.

was able to get the extention to come back but all the hotkeys are messed now. Any suggestions on how I could get the existing hot keys to work?

@zeropoint46
Copy link

@SOSANA sorry I'm not sure whats going on. after I made those changes it just worked as before.

@Fmstrat
Copy link
Owner

Fmstrat commented Apr 25, 2023

It's maintained somewhat by a few people, but the problem is even with those corrections there's some rejections from GNOME for submission due to deprecated calls. I need to do some cleanup and have been unable to spend the time, hopefully soon.

@SOSANA
Copy link

SOSANA commented Apr 25, 2023

@SOSANA sorry I'm not sure whats going on. after I made those changes it just worked as before.

I copied the folder into another directory and removed it using the extensions manager. I re-added original folder with your suggestions that I applied, and logged out and then back in again and it worked as expected.

@zeropoint46 Thank you good sir! You mind if I added you as a friend on discord? Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants