Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why foal does not have HttpResponseTooManyRequests method? #664

Closed
nguyendlp opened this issue Mar 30, 2020 · 2 comments · Fixed by #709
Closed

Why foal does not have HttpResponseTooManyRequests method? #664

nguyendlp opened this issue Mar 30, 2020 · 2 comments · Fixed by #709
Labels
feature request good first issue help wanted
Projects
Issue tracking

Comments

@nguyendlp
Copy link

Hi author,

When using foal, in some cases I want to return HTTP code 429 - Too many requests but foal does not implement this method. Why?

Thanks!
@LoicPoullain
Copy link
Member

No particular reason.

Do you want to submit a PR and add HttpResponseTooManyRequests and isHttpResponseTooManyRequests in packages/core/src/core/http/http-responses.ts?

@LoicPoullain LoicPoullain added this to Backlog in Issue tracking via automation Mar 30, 2020
@LoicPoullain LoicPoullain moved this from Backlog to To Do in Issue tracking Mar 30, 2020
matt-harvey added a commit to matt-harvey/foal that referenced this issue May 16, 2020
@matt-harvey
Add HttpResponseTooManyRequests and isHttpResponseTooManyRequests
c9180e4 
Fixes FoalTS#664
@matt-harvey matt-harvey mentioned this issue May 16, 2020
Merged
3 tasks
@LoicPoullain LoicPoullain moved this from To Do to Work In Progress in Issue tracking May 16, 2020
@LoicPoullain LoicPoullain mentioned this issue May 16, 2020
Merged
12 tasks
@LoicPoullain
Copy link
Member

Fixed in v1.9.0

Issue tracking automation moved this from Work In Progress to Done / Closed This Release May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue help wanted
Projects
Issue tracking
  
Done / Closed This Release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add HttpResponseTooManyRequests and isHttpResponseTooManyRequests matt-harvey/foal
2 participants
@nguyendlp @LoicPoullain