Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpResponseTooManyRequests and isHttpResponseTooManyRequests #709

Merged
merged 8 commits into from
May 16, 2020

Conversation

matt-harvey
Copy link
Contributor

Issue

Fixes #664

Solution and steps

Class and boolean method for 429 HTTP response now provided alongside similar existing class/method pairs.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

I had trouble generating the documentation. npm run docs complained about a lack of various @types packages. A clean npm i did not fix the issue. I had followed the various steps in https://github.com/FoalTS/foal/blob/master/.github/CONTRIBUTING.MD before doing the work.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation May 16, 2020
@LoicPoullain LoicPoullain self-requested a review May 16, 2020 06:54
Copy link
Member

@LoicPoullain LoicPoullain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thks 👍

@LoicPoullain
Copy link
Member

LoicPoullain commented May 16, 2020

I had trouble generating the documentation. npm run docs complained about a lack of various @types packages. A clean npm i did not fix the issue. I had followed the various steps in https://github.com/FoalTS/foal/blob/master/.github/CONTRIBUTING.MD before doing the work.

Yes, I also have problems with this command. I must confess that I haven't updated the API reference for several minor versions because of that. The problem seems to be linked to the noImplicitAny compiler option in tsconfig.json. When set to false the generation works.

EDIT: I opened an issue #710

@LoicPoullain LoicPoullain changed the base branch from master to v1-9-0 May 16, 2020 07:27
@LoicPoullain LoicPoullain merged commit 96143c5 into FoalTS:v1-9-0 May 16, 2020
Issue tracking automation moved this from Work In Progress to Done / Closed This Release May 16, 2020
@LoicPoullain LoicPoullain mentioned this pull request May 16, 2020
12 tasks
@matt-harvey matt-harvey deleted the fix-664 branch May 16, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging this pull request may close these issues.

Why foal does not have HttpResponseTooManyRequests method?
3 participants