Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can ValidateBody be made "Generic" from @foal/typestack? #752

Closed
AleksandrSl opened this issue Jul 9, 2020 · 3 comments
Closed

Can ValidateBody be made "Generic" from @foal/typestack? #752

AleksandrSl opened this issue Jul 9, 2020 · 3 comments

Comments

@AleksandrSl
Copy link
Contributor

We have generic entity controller to reduce amount of code and decorators in other controllers and it's very handy to get values for decorators from child controller, e.g. @ValidateBody((controller: EntityController<any>) => controller.paginatedListSchema).
But for ValidateBody @foal/typestack we can't.
Maybe there is a way to add similar lambda based parameter to get class from controller?

@LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain added this to Backlog in Issue tracking via automation Jul 9, 2020
@AleksandrSl
Copy link
Contributor Author

Thanks, will try to make changes!

@LoicPoullain LoicPoullain moved this from Backlog to Work In Progress in Issue tracking Jul 14, 2020
@LoicPoullain
Copy link
Member

Feature added in v1.10.0

Issue tracking automation moved this from Work In Progress to Done / Closed This Release Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue tracking
  
Done / Closed This Release
Development

No branches or pull requests

2 participants