Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@foal/cli] Validate params in REST APIs #345

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

LoicPoullain
Copy link
Member

Issue

Fixes #344.

Solution and steps

  • Update @foal/cli with the tests.
  • Update the e2e tests.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@codecov
Copy link

codecov bot commented Feb 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (0-7-7@0303b6c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             0-7-7     #345   +/-   ##
========================================
  Coverage         ?   99.32%           
========================================
  Files            ?       37           
  Lines            ?      596           
  Branches         ?      126           
========================================
  Hits             ?      592           
  Misses           ?        4           
  Partials         ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0303b6c...645fbd5. Read the comment docs.

@LoicPoullain LoicPoullain merged commit a7adbb0 into 0-7-7 Feb 7, 2019
@LoicPoullain LoicPoullain deleted the rest-params-validation branch February 7, 2019 07:56
@LoicPoullain LoicPoullain mentioned this pull request Feb 7, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant