Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade graphql and modify tsconfig #624

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Upgrade graphql and modify tsconfig #624

merged 1 commit into from
Jan 28, 2020

Conversation

LoicPoullain
Copy link
Member

Issue

As pointed out in #614 and #623, new versions of graphql needs the esnext.asynciterable lib.

Solution and steps

  • Upgrade graphql version to show the build failure.
  • Modify the tsconfig to fix it.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Jan 28, 2020
6 tasks
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #624 into v1-6-0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           v1-6-0     #624   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          90       90           
  Lines        1632     1632           
  Branches      363      363           
=======================================
  Hits         1626     1626           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3545e...6058ee5. Read the comment docs.

@LoicPoullain LoicPoullain merged commit 6ec82b6 into v1-6-0 Jan 28, 2020
@LoicPoullain LoicPoullain deleted the upgrade-graphql branch January 28, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant