Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@foal/storage] Add hook @ValidateMultipartFormDataBody (file uploads) #651

Merged
merged 23 commits into from
Apr 6, 2020

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Feb 21, 2020

Issue

Closes #560

Solution and steps

  • Create hook
  • Validate fields
  • Treat files (buffers)
  • Treat files (streams)
  • Remove files if invalidation (streams)
  • Add OpenAPI spec
  • Allow to pass size options
  • Handle all errors

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Feb 28, 2020
5 tasks
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (v1-7-0@28196f4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             v1-7-0     #651   +/-   ##
=========================================
  Coverage          ?   99.63%           
=========================================
  Files             ?       90           
  Lines             ?     1630           
  Branches          ?      365           
=========================================
  Hits              ?     1624           
  Misses            ?        6           
  Partials          ?        0
Impacted Files Coverage Δ
...ages/core/src/common/tokens/generate-token.util.ts 100% <ø> (ø)
...src/openapi/metadata-getters/get-api-components.ts 100% <ø> (ø)
...kages/core/src/openapi/create-open-api-document.ts 100% <ø> (ø)
packages/core/src/express/send-response.ts 100% <ø> (ø)
packages/core/src/core/http/http-responses.ts 100% <ø> (ø)
...api/metadata-getters/get-api-complete-operation.ts 100% <ø> (ø)
packages/core/src/common/utils/render.util.ts 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28196f4...4f550e9. Read the comment docs.

@LoicPoullain
Copy link
Member Author

One bash test fails because the new Config.get2 method. This is normal and it is not related to this PR

@LoicPoullain LoicPoullain merged commit ecbc781 into v1-7-0 Apr 6, 2020
@LoicPoullain LoicPoullain deleted the multipart-hook branch April 6, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant