Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other character encodings for JWT secrets #677

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Conversation

LoicPoullain
Copy link
Member

Issue

Fixes #523

Solution and steps

  • Add the option secretEncoding.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Apr 23, 2020
7 tasks
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #677 into v1-8-0 will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1-8-0     #677      +/-   ##
==========================================
+ Coverage   99.41%   99.64%   +0.22%     
==========================================
  Files          70       94      +24     
  Lines        1192     1667     +475     
  Branches      302      371      +69     
==========================================
+ Hits         1185     1661     +476     
+ Misses          7        6       -1     
Impacted Files Coverage Δ
packages/core/src/core/config/utils.ts 100.00% <0.00%> (ø)
packages/core/src/core/routes/utils.ts 100.00% <0.00%> (ø)
packages/core/src/express/not-found.ts 100.00% <0.00%> (ø)
packages/core/src/express/create-app.ts 100.00% <0.00%> (ø)
packages/core/src/sessions/constants.ts 100.00% <0.00%> (ø)
packages/core/src/express/send-response.ts 100.00% <0.00%> (ø)
packages/core/src/core/http/http-methods.ts 100.00% <0.00%> (ø)
packages/core/src/common/utils/escape-prop.ts 100.00% <0.00%> (ø)
packages/core/src/common/utils/render.util.ts 100.00% <0.00%> (ø)
packages/core/src/openapi/utils/merge-tags.ts 100.00% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda6892...9094709. Read the comment docs.

@LoicPoullain LoicPoullain changed the title Support other character encoding for JWT secrets Support other character encodings for JWT secrets Apr 23, 2020
@LoicPoullain LoicPoullain merged commit 27523ac into v1-8-0 Apr 23, 2020
@LoicPoullain LoicPoullain deleted the jwt-encoding branch April 23, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant