Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix renderError error #931

Merged
merged 1 commit into from
May 10, 2021
Merged

Fix renderError error #931

merged 1 commit into from
May 10, 2021

Conversation

LoicPoullain
Copy link
Member

Issue

Fixes #930

Solution and steps

  • Fix the basename call.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain added this to Work In Progress in Issue tracking via automation May 10, 2021
@LoicPoullain LoicPoullain linked an issue May 10, 2021 that may be closed by this pull request
renderError throws an error when another error is thrown with an unexpected traceback. #930
Closed
@LoicPoullain LoicPoullain merged commit f3917cc into v2-4-0 May 10, 2021
Issue tracking automation moved this from Work In Progress to Done / Closed This Release May 10, 2021
@LoicPoullain LoicPoullain deleted the fix-render-error branch May 10, 2021 12:36
@LoicPoullain LoicPoullain mentioned this pull request May 10, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
Issue tracking
  
Done / Closed This Release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

renderError throws an error when another error is thrown with an unexpected traceback.
1 participant
@LoicPoullain