Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderError throws an error when another error is thrown with an unexpected traceback. #930

Closed
LoicPoullain opened this issue May 10, 2021 · 1 comment · Fixed by #931
Closed
Labels

Comments

@LoicPoullain
Copy link
Member

LoicPoullain commented May 10, 2021

The renderError function is used to render in a pretty way errors that have been thrown in the app. It extracts some data from the traceback to display the error. In the some situations, the stack trace does not have the format that was expected and the function throws an error.

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
[1]     at validateString (internal/validators.js:120:11)
[1]     at Object.basename (path.js:1156:5)
[1]     at Object.renderError (/Users/loicpoullain/Desktop/react-foal-tuto/backend-app/node_modules/@foal/core/lib/common/utils/render-error.util.js:31:30)
[1]     at Object.getResponse (/Users/loicpoullain/Desktop/react-foal-tuto/backend-app/node_modules/@foal/core/lib/core/routes/get-response.js:30:24)
[1]     at /Users/loicpoullain/Desktop/react-foal-tuto/backend-app/node_modules/@foal/core/lib/express/create-app.js:86:34

@LoicPoullain LoicPoullain added this to Backlog in Issue tracking via automation May 10, 2021
@LoicPoullain LoicPoullain mentioned this issue May 10, 2021
4 tasks
@LoicPoullain LoicPoullain linked a pull request May 10, 2021 that will close this issue
4 tasks
@LoicPoullain LoicPoullain moved this from Backlog to Work In Progress in Issue tracking May 10, 2021
@LoicPoullain LoicPoullain mentioned this issue May 10, 2021
4 tasks
@LoicPoullain
Copy link
Member Author

Fixed in v2.4

Issue tracking automation moved this from Work In Progress to Done / Closed This Release May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Issue tracking
  
Done / Closed This Release
Development

Successfully merging a pull request may close this issue.

1 participant