Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library infrastructure, fix release issue #12

Merged
merged 6 commits into from
Feb 6, 2023
Merged

Update library infrastructure, fix release issue #12

merged 6 commits into from
Feb 6, 2023

Conversation

tekktrik
Copy link
Contributor

@tekktrik tekktrik commented Feb 4, 2023

  • Fix version string to be 0.0.0+auto.0
  • Updates the CI to use the new composite actions, so now updates to those come to you without any local update needed.
  • setup.py isn't strictly needed here since everything can be moved to pyproject.toml, so I moved all the information over to that.
  • New CI uses Python 3.11, so I pinned pygame to the minimum version that will work for it. Unfortunately no non-pre-released version is available that fits that criteria.
  • Due to the Python 3.11 upgrade, pylint also needed an update, so I updated it to 2.15.5 like the other libraries and regenerated .pylintrc which has changes to what options are available so it appears as a substantial change to that file.
  • Added one pylint disable to the file since it pops out with the new pylint version.

I think that's everything. Happy to remove any of these here if they're too out of scope of fixing the original release issue I was targeting, just be aware a lot of these cascade into other fixes which I tried to detail.

@tekktrik
Copy link
Contributor Author

tekktrik commented Feb 4, 2023

Fixes #10

Copy link
Owner

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all of the updates @tekktrik!

Looks good to me. I double checked this branch locally to ensure examples still run with the old pygame, and also tried the new pinned version of pygame in a venv on my system to make sure it can work under python 3.10 which is what I have locally.

I'll try to remember to check back in after a while to see if pygame has made a major release to go back to having it unpinned here.

@FoamyGuy FoamyGuy merged commit 3ee091a into FoamyGuy:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants