Add support for timing VB.net async methods #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeertvanHorrik
approved these changes
Feb 9, 2021
|
@SimonCropp , I've reviewed and it looks good. The actual code changes are just 2 additional checks and they are all covered by unit tests so I am happy to vote for accepting this PR even though I am not sure what your official point of supporting VB.NET is. |
|
the pr looks good. i am curious about the choice to remove the part about being a patron on open collective. |
|
sorry about removing the patron section from description, i took it as a fyi and deleted. can pop it back in if required wasnt aware about patron criteria, until i raised the issue + pr. it did prompt me make the contribution last night tho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to time async methods on vb.net assemblies
The solution
Search for method ending in
$StateTodos