Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .NET Framework 4.0? #270

Closed
MarkLTX opened this issue Jul 10, 2017 · 11 comments
Closed

Support for .NET Framework 4.0? #270

MarkLTX opened this issue Jul 10, 2017 · 11 comments

Comments

@MarkLTX
Copy link

MarkLTX commented Jul 10, 2017

I stumbled across this comment...
"version 2 has been moved to netstandard1.3 which means you need to update to at least .net 4.6."

I'm no sure what that means.

Does it mean I can't target the 4.0 framework in my projects that use PropertyChanged.Fody?

Or does it just mean I need .net 4.6 on my build machine?

@tom-englert
Copy link
Member

Currently you can't even use it with Net4.0.
PR #273 can fix this.

@SimonCropp
Copy link
Member

It supports 4.5 and up. I am not sure there is a compelling reason that it should support a framework released 7 years ago with support ending last year

@tom-englert
Copy link
Member

In industry the reality is different - there is a lot of legacy code and hardware around.
If you compile against 4.0 (because you e.g. don't need any of the new features), it will happily run on 4.7, but also still works on the old isolated controller hardware working for years without the need to update it.

Since there is nearly no effort to support both, why don't do it?

@MarkLTX
Copy link
Author

MarkLTX commented Aug 4, 2017

I don't WANT to target 4.0. I HAVE to target 4.0. My company runs a billion dollar business with commercial software that is not compatible with later versions of .NET. I have no power to change this.

Lack of support for 4.0 is killing me. I can use the older nuget package for now but I'm extremely reluctant to use Fody for any new development at this time after getting the rug pulled out from under me.

@SimonCropp
Copy link
Member

@MarkLTX how about this. point me to one significant contribution your billion dollar business has made to any open source project in the past month and i will go to the effort of supporting .net 4.0

@SimonCropp
Copy link
Member

SimonCropp commented Aug 4, 2017

i guess my underlying problem with this scenario is: you have a problem "your company refuses to keep their software reasonably up to date", and your request for a free open source project to keep supporting you is, in effect, attempting to make your problem someone else problem.

you need to be highlighting to your organisation that the longer you leave things out updated the more friction that will cause in development for people trying to use newer tools.

based on your current argument, if any raises an issue with "my company refuses to move off ,net 2/3 or 4" then the community should support that no questions asked.

There has to be some point at which there is diminishing returns combined with increasing effort to support, that a project should be able to say "i am sorry we cant support that"

@tom-englert
Copy link
Member

@SimonCropp reality is much more complicated, it's not just "my company", it's also all customers in the world with their IT, support engineers and a lot more ...
Sometimes it's really makes your live easier to demand only Net4.0 just to avoid endless discussions and support calls upfront.
I hope my open source contributions are enough to qualify me for requesting that feature, since it only needs to merge PR #273 to fix it 😏

@dss539
Copy link

dss539 commented Aug 25, 2017

While @SimonCropp is certainly correct that no one should demand something with an entitled attitude, @tom-englert has apparently provided the work to make it happen.

If there is no increased burden or downside for merging #273 then it would be best to accept it. If there is some negative aspect to it, then by all means reject it. Then @tom-englert would just have to fork PropertyChanged.Fody to provide that support if he's willing.

@tom-englert
Copy link
Member

tom-englert commented Sep 18, 2017

@SimonCropp just stepped over this issue again:
Even though our application is using .Net4.6, the WiX Bootstrapper of course must be .Net 4.0 client, since it's impossible to install .Net4.6 from within an application that already reqiures .Net4.6.
Since we can't assume that .Net4.6 or newer is already installed on every machine, the setup bootstapper must be able to start on .Net4.0client and upgrade .Net if necessary.

So it would be great if you could accept my PR so we can keep our packages up to date.

@SimonCropp
Copy link
Member

SimonCropp commented Sep 25, 2017

@tom-englert i really want to help here. But the long term ramifications of saying yes anytime someone asks to support an older runtime, are not maintainable for me moving forward. Take you wix example, someone could equally say "tool x only supports net 3, can u support that" and based on the arguments above i would have to support it.

Btw it looks like wix does have checks for net 462 https://stackoverflow.com/questions/39896281/ and if it doens u really should be pushing the wix team to add native support for supported version of net. If they have no plans to then it is probably abandonware and u should start planning on how to remove that dependency. Also ether r significant bug fixes and per improvements in newer versions of net. Being stuck on an older versions due to a dodgy installer is something u need to find a solution to

So again really sorry. But i am going to close this. I have also clarified the supported versions here https://github.com/Fody/Fody#supported-runtimes

@arackaf
Copy link

arackaf commented Feb 9, 2019

Yo @MarkLTX - how much money is your billion dollar company willing to pay to the maintainers of this OSS project to support .net 4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants