used Zip4j library and bug fixed #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mahavir155
commented
May 16, 2018
•
mahavir155
commented
- Zip4j library
- Font issue
- Fixes FolioReader/FolioReader-Android#174
- Fixes FolioReader/FolioReader-Android#181
- Fixes FolioReader/FolioReader-Android#204
- Fixes FolioReader/FolioReader-Android#205
- Code refactoring
Code refactor
FolioReader#204 Regex used for finding possible breakpoints - \'\"\s\+\s\w+\s\+\s\"\'\" \'\"\s\+\s\w+.\w+\(\)\s\+\s\"\'\" \'\"\s+\+\s+\w+.\w+\(\)\s+\+\s+\"\'
FolioReader#205 Now code navigate back to prevoius activity even if app was minimised.
Previously no other font specified in epub webpages were given preference because CSS injection had !important and fonts were also specified to p, span, div tags. Test Files - [hindi1.epub] (https://www.dropbox.com/s/0f98gq5cnrw31ga/hindi1.epub?dl=0)
Unable to reproduce the bug on adventures.epub and TheSilverChair.epub, but still exception catched and handled.
Fixes FolioReader#174 Fixes FolioReader#181 Fixes FolioReader#204 Fixes FolioReader#205
Code refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.