Horizontal scroll code for v0.4.0 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scroll Feature/horizontal scroll
Behaviour changes: onSaveInstanceState - https://developer.android.com/reference/android/app/Activity#onSaveInstanceState(android.os.Bundle) cleartextTrafficPermitted - https://developer.android.com/preview/features/security-behav#tls-enabled FLAG_ACTIVITY_NEW_TASK - https://developer.android.com/preview/behavior-changes#fant-required
…scroll Feature/horizontal scroll
…/horizontal_scroll
…/horizontal_scroll
When a xhtml contents is loaded with text/html MIME type, the page might load into Quirks mode. So it is neccessary to load xhtml pages with application/xhtml+xml MIME type. If the page gets loaded in Quirks mode, then majority of the modern CSS styles might not work. References - https://stackoverflow.com/questions/8052178/difference-between-document-documentelement-clientheight-and-document-body-clien https://en.wikipedia.org/wiki/Quirks_mode
document.documentElement.scrollWidth gives incorrect value when the webview is busy re-drawing contents. Reproducable only on Android Chrome and not on Desktop Chrome.
This is done because if the html and body has its own margins then vertical direction doesn't have any issue but for horizontal direction pagination layout breaks.
If the text is set here then it would change only when next page is selected.
Horizontal scroll code for v0.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.