-
Notifications
You must be signed in to change notification settings - Fork 765
FolioReaderCenter.getCurrentChapterName() issue, applied recursive search for toc reference. #342
Conversation
…fter select any color in menu. https://github.com/FolioReader/FolioReaderKit/issues/316
…fter select any color in menu. https://github.com/FolioReader/FolioReaderKit/issues/316 (reverted from commit b8cccd7)
…ence. (reverted from commit 4577d99)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, the only thing is the question about the removal of contentInsetAdjustmentBehavior
Source/FolioReaderCenter.swift
Outdated
@@ -157,10 +157,6 @@ open class FolioReaderCenter: UIViewController, UICollectionViewDelegate, UIColl | |||
enableScrollBetweenChapters(scrollEnabled: true) | |||
view.addSubview(collectionView) | |||
|
|||
if #available(iOS 11.0, *) { | |||
collectionView.contentInsetAdjustmentBehavior = .never |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fix for a bug on iOS 11 collectionView scroll, why did you remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to this for more info: 0f161dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sory sorry, i reverted incorrect commit.
Fixed! 658e0ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
* 'master' of github.com:FolioReader/FolioReaderKit: (51 commits) Migrating documentation from cocoadocs to github pages Removing extra spaces Fix fast scroll bug (FolioReader#379) Migrated the Xcode project to use swift 4.2 Updated Cartfile to not use JSQWebViewController Bump minimum version support to iOS 9 and removed legacy JSQWebViewController Update FolioReaderKit.podspec Update README.md Update CHANGELOG.md Changed dependencies to work with iOS 12.1 and Xcode 10.1 (FolioReader#377) Fix crash on select segment at index. Swift 4.2 (FolioReader#361) Update issue templates method to get current progress between 0 and 100 (FolioReader#348) FolioReaderCenter.getCurrentChapterName() issue, applied recursive search for toc reference. (FolioReader#342) Fixed FolioReaderWebView, menu controller still showing colors menu after select any color in menu. (FolioReader#339) Fix iOS 11 auto adjust inset bug and closes #332 #312 #261 Update Cocoapods version Add Note function (FolioReader#335) Update LICENSE Fixed getCurrentChapter(), not returning some chapters, closes #302 thanks to @wesleycgs ...
Same error that was fixed in
FolioReaderCenter.getCurrentChapter()
.Fixed
FolioReaderCenter.getCurrentChapterName()
, applied recursive search for toc reference.