Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global, AMD and CommonJS definition #532

Merged
merged 2 commits into from
May 23, 2018
Merged

Conversation

sarunint
Copy link
Contributor

@sarunint sarunint commented May 23, 2018

Fix #470
Fix #479
Supersedes #529

@sarunint
Copy link
Contributor Author

Hi, @thedustinsmith,

I confirm that this PR works in both global, and in Webpack/TypeScript configuration.

This PR is based on your branch.

@thedustinsmith thedustinsmith merged commit 8dc634a into Foliotek:master May 23, 2018
@thedustinsmith
Copy link
Contributor

Thanks!

@sarunint sarunint deleted the umd branch May 23, 2018 12:38
sarunint added a commit to sarunint/DefinitelyTyped that referenced this pull request May 23, 2018
This will work after Foliotek/Croppie#532 got included into a release.

Close DefinitelyTyped#21928
sarunint added a commit to sarunint/DefinitelyTyped that referenced this pull request May 23, 2018
This will work after Foliotek/Croppie#532 got included into a release.

Close DefinitelyTyped#21928
sarunint added a commit to sarunint/DefinitelyTyped that referenced this pull request May 23, 2018
This will work after Foliotek/Croppie#532 got included into a release.

Close DefinitelyTyped#21928
@sarunint
Copy link
Contributor Author

sarunint commented Jun 2, 2018

@thedustinsmith Is this going to be released anytime soon? DefinitelyTyped/DefinitelyTyped#25962 is blocked on this.

@thedustinsmith thedustinsmith mentioned this pull request Aug 8, 2018
@emilyaviva
Copy link

@thedustinsmith I am similarly blocked on using Croppie in a project because I can't import it into a modern TypeScript app. Are there any plans to release 2.6.3 containing this change? Failing that, do you know how one can point one's package.json to use the code in master instead of the 2.6.2 release?

@thedustinsmith
Copy link
Contributor

I'm pretty sure you can do npm install Foliotek/Croppie#master or something along those lines. A google search for "npm install git repo branch" should get you pointed in the right direction.

By the way, thanks for taking the initiative to help out and get this one tested. I appreciate it.

@thedustinsmith
Copy link
Contributor

Forgot to mention you in my comment above @emilyaviva

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants