-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix global, AMD and CommonJS definition #532
Conversation
Hi, @thedustinsmith, I confirm that this PR works in both global, and in Webpack/TypeScript configuration. This PR is based on your branch. |
Thanks! |
This will work after Foliotek/Croppie#532 got included into a release. Close DefinitelyTyped#21928
This will work after Foliotek/Croppie#532 got included into a release. Close DefinitelyTyped#21928
This will work after Foliotek/Croppie#532 got included into a release. Close DefinitelyTyped#21928
@thedustinsmith Is this going to be released anytime soon? DefinitelyTyped/DefinitelyTyped#25962 is blocked on this. |
@thedustinsmith I am similarly blocked on using Croppie in a project because I can't import it into a modern TypeScript app. Are there any plans to release 2.6.3 containing this change? Failing that, do you know how one can point one's package.json to use the code in |
I'm pretty sure you can do By the way, thanks for taking the initiative to help out and get this one tested. I appreciate it. |
Forgot to mention you in my comment above @emilyaviva |
Fix #470
Fix #479
Supersedes #529