Bug/securetoken #71
Bug/securetoken #71
Conversation
|
Are there any reviewers? |
Hi! Thanks again for this feature fix. We haven't forgotten this and will get to it soon. Apologies that we've been internally backlogged and it's taken us some time to review. |
| @@ -15,7 +16,7 @@ export const config = (cmdObj) => { | |||
| console.log(chalk.cyanBright("Your current config:")); | |||
| console.log(`github username: ${getConfig("github")}`); | |||
| console.log( | |||
| `token: ${getConfig("token") ? "<hidden>" : "undefined"}` | |||
| `token: ${getConfig("token") ? `<hidden>` : "undefined"}` | |||
There was a problem hiding this comment.
Is there a reason quotes had to be changed? For consistency purposes, if they didn't need to be changed, revert this back.
| @@ -44,7 +44,7 @@ export const createProgram = (args) => { | |||
| .description("Set up or view config (Github credentials etc.)") | |||
| .option("-v, --view", "view current config") | |||
| .option("-g, --github <username>", "set github username") | |||
| .option("-t, --token <token>", "set github personal access token") | |||
| .option("-t, --token", "set github personal access token") | |||
There was a problem hiding this comment.
<token> made the token a required argument for this command; Why did you remove it? Setting a Github token to undefined and getting the message Successfully set GitHub personal access token. is a bad flow.
| @@ -18,6 +18,14 @@ const ghUsernameRegex = new RegExp( | |||
| "i" | |||
| ); | |||
|
|
|||
| const TOKEN = { | |||
There was a problem hiding this comment.
This file is for the creation of new projects not for adding to the config. Lines 21-28 and lines 112-119 need to be extracted to a new file
|
Accidentally request review again. Please ignore. |
|
I currently have an unsolvable node / yarn issue in running the cli on dev. I don't think I can fix this. Thanks for the time. |
What type of PR is this? (check all applicable)
Description
Fixed issue [#39 ]
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?
