New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Fonts integration (along with libsoup and webkit) should be optional #137
Comments
Well, if I'm not mistaken WebKit requires libsoup, actually a ton of stuff requires libsoup. But yes WebKit is required for the previews and it's definitely heavy and should be a build option. I'll be looking into it over the weekend. Thanks for the motivation. |
Can you try the latest commit and confirm that it works as expected please. I'll probably do another release within the next couple of days. Hoping to sort out #135 if possible before doing so. Thanks. |
I have compiled it twice. One without webkit and another one with it. So I think, this issue is fixed now. Thank you @JerryCasiano very much, you're awesome. If only all of the opensource projects were maintained like you do yours… |
Thanks for verifying this. Linking the related bug report here just in case... |
Recent changes of integrating Google Fonts, while admittedly being a very nice feature to have, introduced a dependency on libsoup and network activity. Some users might prefer to avoid network activity and not to have a hard dependency on libsoup.
Oh, btw, does this feature also require webkit? That's a heavy dependency also.
Separating this issue from #54.
The text was updated successfully, but these errors were encountered: