Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Fonts integration (along with libsoup and webkit) should be optional #137

Closed
PF4Public opened this issue Nov 27, 2020 · 4 comments
Closed

Comments

@PF4Public
Copy link
Contributor

PF4Public commented Nov 27, 2020

Recent changes of integrating Google Fonts, while admittedly being a very nice feature to have, introduced a dependency on libsoup and network activity. Some users might prefer to avoid network activity and not to have a hard dependency on libsoup.

Oh, btw, does this feature also require webkit? That's a heavy dependency also.

Separating this issue from #54.

@PF4Public PF4Public changed the title Google Fonts integration (along with libsoup) should be optional Google Fonts integration (along with libsoup and webkit) should be optional Nov 27, 2020
@JerryCasiano
Copy link
Contributor

Oh, btw, does this feature also require webkit? That's a heavy dependency also.

Well, if I'm not mistaken WebKit requires libsoup, actually a ton of stuff requires libsoup. But yes WebKit is required for the previews and it's definitely heavy and should be a build option.

I'll be looking into it over the weekend. Thanks for the motivation.

@JerryCasiano
Copy link
Contributor

Can you try the latest commit and confirm that it works as expected please.

I'll probably do another release within the next couple of days. Hoping to sort out #135 if possible before doing so.

Thanks.

@PF4Public
Copy link
Contributor Author

I have compiled it twice. One without webkit and another one with it.
Without it ldd /usr/bin/font-manager |grep -i webk is empty and there is no G letter in the title and it works fine, as expected. With it it pulls in webkit and also works fine. ldd /usr/bin/font-manager |grep -i webk now shows libwebkit2gtk-4.0.so.37 => /usr/lib64/libwebkit2gtk-4.0.so.37 (0x00007efe0a5c9000).

So I think, this issue is fixed now.

Thank you @JerryCasiano very much, you're awesome. If only all of the opensource projects were maintained like you do yours…

@JerryCasiano
Copy link
Contributor

Thanks for verifying this.

mesonbuild/meson#8040

Linking the related bug report here just in case...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants